Fix bamboo build number being empty#1
Merged
TheSnoozer merged 1 commit intogit-commit-id:masterfrom Jul 5, 2021
Merged
Conversation
TheSnoozer
requested changes
Jul 5, 2021
Contributor
TheSnoozer
left a comment
TheSnoozer
left a comment
There was a problem hiding this comment.
Hello,
thank you for your contribution and doing the research where this comes from!
Indeed that sounds like the right place to make this adjustment.
Could you please take a brief look at the comment I left?
Besides that I think this good to be merged.
Thanks again for your contribution!
TheSnoozer
requested changes
Jul 5, 2021
Contributor
TheSnoozer
left a comment
TheSnoozer
left a comment
There was a problem hiding this comment.
Hello,
thank you for your contribution and doing the research where this comes from!
Indeed that sounds like the right place to make this adjustment.
Could you please take a brief look at the comment I left?
Besides that I think this good to be merged.
Thanks again for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed, that the field
git.build.numberwas empty on our Bamboo (v7.2.3). After a bit of digging, I found that it has to do with the environment variables which the plugin is reading. It's readingbamboo.buildNumberandBAMBOO_BUILDNUMBER, however bamboo is only settingbamboo_buildNumber.In the documentation (https://confluence.atlassian.com/bamboo/bamboo-variables-289277087.html#Bamboovariables-Systemvariables) under "System variables" it is explained that "Bamboo Variables" are converted to shell variables by converting any dot to an underscore. My understanding is that Bamboo Variables like "bamboo.buildNumber" are only substituted when used in a command or script task in Bamboo.
Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B